Skip to content

Conversation

edersonbrilhante
Copy link
Contributor

PR Description

Implements support for splitting the runner matcher configuration across multiple SSM parameters.
PARAMETER_RUNNER_MATCHER_CONFIG_PATH can now accept multiple parameter paths separated by a colon (:).

This avoids SSM size limits for large configurations and improves scalability for environments with many runner types and labels.

Closes #4790

@edersonbrilhante edersonbrilhante requested a review from a team as a code owner September 25, 2025 22:31
@github-actions github-actions bot requested a review from a team as a code owner October 3, 2025 10:50
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edersonbrilhante nice contribution. I just tried the parameter split with the multi-runner example in this repo. By adding a few config and adding more labes. Result is I got this error, related to the added foreach

│
│   on ../../modules/webhook/webhook.tf line 27, in resource "aws_ssm_parameter" "runner_matcher_config":
│   27:   for_each = { for idx, val in local.matcher_chunks : idx => val }
│     ├────────────────
│     │ local.matcher_chunks will be known only after apply
│
│ The "for_each" map includes keys derived from resource attributes that cannot be determined until apply, and so Terraform cannot determine the full set of keys that will
│ identify the instances of this resource.
│
│ When working with unknown values in for_each, it's better to define the map keys statically in your configuration and place apply-time results only in the map values.
│
│ Alternatively, you could use the -target planning option to first apply only the resources that the for_each value depends on, and then apply a second time to fully
│ converge.

Wondering you you tested the change? I was not able to get it working right now.

@edersonbrilhante
Copy link
Contributor Author

I did test it, but I forgot to include a large configuration and only tested the normal case. My bad. I found the same bug now.

@edersonbrilhante
Copy link
Contributor Author

@npalm I just pushed my fix. I tested a normal config and a tested a really big one with 7 ssm resources and it worked fine now.

@edersonbrilhante
Copy link
Contributor Author

edersonbrilhante commented Oct 3, 2025

@npalm Also, during this fix I found 1 bug created the last release.
Check this PR #4806

@npalm
Copy link
Member

npalm commented Oct 8, 2025

Thx for the updates, will not be able to able to get the PR merged in the next weeks. I will catch up end of the month. Sorry for tthe delay.

@edersonbrilhante
Copy link
Contributor Author

No problem. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSM Parameter Size Limit Hit for Runner Matcher Config

3 participants